Thanks for taking the time to contribute!
The following is a set of guidelines for contributing. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request.
- Contributing to TruBudget
This project and everyone participating in it is governed by our Code of Conduct. By participating, you are expected to uphold this code. Please report unacceptable behavior to Jure Zakotnik, who is the current project maintainer.
If this is your first time starting TruBudget, you should follow the Developer Setup for setting up the project.
Feel free to help out if you noticed a bug or if you want to suggest a new feature by simply opening a new github issue
When working on a feature, you can open a PR in as soon as you push the first changes. Please make sure you follow these guidelines regarding PRs:
- Make sure that the PR description clearly describes what you are working on
- If aplicable, mention what issue will be closed with this pull request, by typing
- Describe how you are planning on implementing the soultion, maybe by creating a TODO list
- The PR should be in draft mode if you're still making some changes. If it is ready to be reviewed then mark it as "Ready for review"
If you make changes that are relevant to the end user you should add an entry in the CHANGELOG.md file, which can be found in the root folder of the project. Before adding to the changelog, you should read these guidelines
When writing commits you should consider the following guidelines:
- Follow these git commit guidelines
- Always include a prefix in the commit message with the abbreviation of the project you're working on (api, bc, doc, UI, e2e-test, excel-export, email-service)
- When you're only changing the documentation you can include
[ci skip]in the commit title
When creating a new branch, you should consider the following guidelines regarding branch names:
- Lead with the number of the issue you are working on
- Add a short description of what the task is about
- Use hyphens as separators
To get an idea about the workflow used in our project you should read this how to / git. So when working on a feature branch make sure to:
- Checkout the master branch and pull the recent changes
- Create a new feature branch respecting the guidelines mentioned above
- Try to keep the commits separate and respect the guidelines mentioned above. Don't squash the commits into a single one especially if you changed a lot of files
- Push to the remote repository and open a pull request respecting the guidelines mentioned above
- Make sure the pipelines are passing
- Wait for a review. If you need a specific team member to review the PR you can request a review from them and assign them to the PR
- When your feature is ready make sure you have the latest changes by running
$ git pull --rebase origin masteron your feature branch and push the changes
- Merge the pull request into master
When we make a significant decision in how to write code, or how to maintain the project and what we can or cannot support, we will document it using Architecture Decision Records (ADR). Take a look at the doc/architecture/decisions directory for existings ADRs. If you have a question around how we do things, check to see if it is documented there. If it is not documented there, please ask us - chances are you're not the only one wondering. Of course, also feel free to challenge the decisions by starting a discussion on GithubDiscussions or by opening a new github issue.
Best practices and layout is documented in README files next to the source files they describe. For example, take a look at api/src/ to get started.